Back to All

NPM package for median js bridge out of sync with documentation

When checking your documentation here:

https://median.co/docs/internal-vs-external-links

and checking your actual implementation here:

https://github.com/gonativeio/median-javacript-bridge/blob/main/src/commands/general.ts

there's a bunch of stuff which isn't aligned.

median.window.open(url, mode) doesn't take a mode parameter according your implementation here https://github.com/gonativeio/median-javacript-bridge/blob/main/src/commands/general.ts#L308C2-L310C5

Also the way the links should be configured at runtime doesn't align with your documentation. According to your documentation we have to pass an array like:

var rulesArray = [ { "id": 1, "regex": "https?://maps\\.google\\.com._", "mode": "external" }, { "id": 2, "regex": "https?://([-\\w]+\\.)_google\\.com/maps/search/._", "mode": "external" }, { "id": 3, "regex": "https?://([-\\w]+\\.)_linkedin\\.com/._", "mode": "external" }, { "id": 4, "regex": "https?://([-\\w]+\\.)_nytimes\\.com/._", "mode": "appbrowser" }, { "id": 5, "regex": "https?://([-\\w]+\\.)_wsj\\.com/.*", "mode": "appbrowser" } ];

But typescript complains that entries in the rules array should have an internal property instead.